Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate nonlocal games #1596 task1 classical #1710

Merged
merged 28 commits into from
Jul 16, 2024
Merged

Migrate nonlocal games #1596 task1 classical #1710

merged 28 commits into from
Jul 16, 2024
+176 −0

Conversation

ggridin
Copy link
Contributor

@ggridin ggridin commented Jul 9, 2024 •
edited
Loading

The link to the issue: #1596

This pull requests is covering

  1. inital folder structure for nonlocal_games
  2. CHSH classical tasks (1.1 and 1.2/3)

Other PRs will follow after this commit.

Details of this PR:

Context is (mostly) copied from previous version QuantumKatas.

  1. index.md for nonlocal_games is added.
    • Brief overview for nonlocal games is new.
  2. chsh_classical_win_condition (task 1.1) is added.
    • index.md: Reference to Q# samples is rephrased to point to this the kata (reference implementation will be added in next quantum PR).
  3. chsh_classical_strategy (combined tasks 1.2 1.3) is added.
  4. Conclusion section sentence is new.

Testing done:
0. Build "python ./build.py --npm" is successful

  1. Placeholder cases are syntactically correct but failing verifications.
  2. Solutions are successful.
  3. Some other failure scenarios were tested manually.
  4. Content screenshots are attached.
    CHSH game Classical -1
    CHSH game Classical Win Condition - 2
    CHSH game Classical Strategy -3

Manvi-Agrawal
Manvi-Agrawal suggested changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Manvi-Agrawal Manvi-Agrawal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I some comments, mostly nitpicks with one major change to remove the current kata from index.json list. We add it once kata is ready to publish :-)

@ggridin ggridin mentioned this pull request Jul 12, 2024
Open
3 tasks
tcNickolas
tcNickolas suggested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience with my review!
Looks good overall! I didn't realize that we can just have two functions in the task without any issues. This used to not be the case in the Jupyter notebook version of the katas, so I didn't even think about that in the modern katas - I'm glad you discovered that rather than do my proposed tuples approach!

I left some comments, formatting and phrasing.

Thank you!

ggridin and others added 9 commits July 12, 2024 12:40
@ggridin
Merge branch 'microsoft:main' into MigrateNonlocalGames-1596-task1-cl…
85f59ec 
…assical
@ggridin @tcNickolas
Update katas/content/nonlocal_games/index.md
b8db86a 
Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/index.md
f37b9b7 
Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/index.md
54aa6f2 
Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/index.md
77f83db 
Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/index.md
b85b080 
Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/chsh_classical_win_condition/Veri…
67cbd3d 
…fication.qs

Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/chsh_classical_win_condition/solu…
9523937 
…tion.md

Co-authored-by: Mariia Mykhailova <[email protected]>
@ggridin @tcNickolas
Update katas/content/nonlocal_games/chsh_classical_strategy/index.md
4ae50af 
Co-authored-by: Mariia Mykhailova <[email protected]>
tcNickolas
tcNickolas reviewed Jul 13, 2024
View reviewed changes
Copy link
Contributor

@tcNickolas tcNickolas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one tiny formatting suggestion I missed on the previous iteration. (And the two comments from the previous iteration, I missed that they're not resolved yet)

Thank you!

@billti billti added this pull request to the merge queue Jul 16, 2024
Merged via the queue into microsoft:main with commit 1deae14 Jul 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manvi-Agrawal Manvi-Agrawal Manvi-Agrawal requested changes

@tcNickolas tcNickolas tcNickolas approved these changes

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc

@sezna sezna Awaiting requested review from sezna

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggridin @tcNickolas @Manvi-Agrawal @DmitryVasilevsky @billti